-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update to newer kcp apimachinery, logicalcluster packages #27
Conversation
Hi @fgiloux. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@fgiloux: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@stevekuznetsov @varshaprasad96 anything blocking the PR? |
/ok-to-test |
/hold |
The test failures are because of the upgrade to go 1.18. If you want to make that change, we'll either need to cherry-pick whatever fixed it upstream, or add an |
Thank you for pointing that out. I have cherry picked the upstream change related to the upgrade of controller-runtime from 1.17 to 1.19 (they never had 1.18). My original idea was to align the go version here with the version used in other kcp repositories. I am not sure anymore that it is a good idea due to the divergence with the controller-runtime version. Thoughts? |
Let's align this with upstream controller-runtime |
- github.com/kcp-dev/apimachinery v0.0.0-20220922165458-607ac5e87531 - github.com/kcp-dev/logicalcluster/v2 v2.0.0-alpha.3 Fix wrong index name for list calls (trailing |) Signed-off-by: Frederic Giloux <fgiloux@redhat.com>
ack. I reverted to go 1.17 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
This brings controller-runtime to the latest kcp versions
and go 1.18:With the new version an issue with list appeared where the index name used for the search has a trailing piple "|". A fix for it is also part of the PR.
Signed-off-by: Frederic Giloux fgiloux@redhat.com